Minor fixes for strfry #4

Merged
hoytech merged 6 commits from master into master 2024-09-10 17:25:21 +12:00
hoytech commented 2024-09-10 15:16:09 +12:00 (Migrated from github.com)

Very cool test-suite! I ran it against strfry and encountered some minor issues, which I have fixed. I guess a couple of them are open for interpretation, but I believe strfry implements allowable behavour in these cases so the test-suite should be adjusted:

  • Always rejects empty tags (ie "tags":[[]])
  • Treats PRE (events in the 30k range) without a d tag as replaceable, and therefore deletes the previous
Very cool test-suite! I ran it against strfry and encountered some minor issues, which I have fixed. I guess a couple of them are open for interpretation, but I believe strfry implements allowable behavour in these cases so the test-suite should be adjusted: * Always rejects empty tags (ie `"tags":[[]]`) * Treats PRE (events in the 30k range) without a `d` tag as replaceable, and therefore deletes the previous
mikedilger commented 2024-09-10 17:25:33 +12:00 (Migrated from github.com)

Hey that all looks good. Thanks!

(I should not have force pushed, caused a collision. Oh well I learn).

Hey that all looks good. Thanks! (I should not have force pushed, caused a collision. Oh well I learn).
Sign in to join this conversation.
No description provided.