nostr/relay-manager
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity Actions

stop duplicating payload in the body of the event #2

Merged
fiatjaf merged 1 commit from patch-2 into master 2024-07-09 15:14:56 +12:00
Conversation 4 Commits 1 Files changed 1 +1 -1
fiatjaf commented 2024-07-09 14:55:23 +12:00 (Migrated from github.com)
Copy link

Sorry, I edited this file on GitHub so it's probably broken, but I don't know if this is correct. Are you taking the same content sent in the body of the POST and putting it inside the event which is then base64d and sent as a header? This feels wrong, I think we can get away with just the hash of the content, no?

Also, maybe we should remove the URL and method from the tags because they're completely irrelevant (I know NIP-98 mentions them, but still we gain nothing by following that).

Sorry, I edited this file on GitHub so it's probably broken, but I don't know if this is correct. Are you taking the same content sent in the body of the POST and putting it inside the event which is then base64d and sent as a header? This feels wrong, I think we can get away with just the hash of the content, no? Also, maybe we should remove the URL and method from the tags because they're completely irrelevant (I know NIP-98 mentions them, but still we gain nothing by following that).
mikedilger commented 2024-07-09 15:14:40 +12:00 (Migrated from github.com)
Copy link

Oh shit! Good catch. That was not what I thought I had done. I must be having Joe Biden moments.

Oh shit! Good catch. That was not what I thought I had done. I must be having Joe Biden moments.
mikedilger commented 2024-07-09 15:20:29 +12:00 (Migrated from github.com)
Copy link

The url and method limit the scope of replays. But if all commands are idempotent (and I think they are) then it doesn't really matter. So we could remove them. Or we could just pare it back to the host which limits replay onto other hosts running the same software.

The url and method limit the scope of replays. But if all commands are idempotent (and I think they are) then it doesn't really matter. So we could remove them. Or we could just pare it back to the host which limits replay onto other hosts running the same software.
fiatjaf commented 2024-07-09 15:23:58 +12:00 (Migrated from github.com)
Copy link

OK, I think the host makes sense. I hadn't thought about replays. Let's do that. I should write this on the NIP.

The full URL and method don't really do anything since they're always the same, no?

OK, I think the `host` makes sense. I hadn't thought about replays. Let's do that. I should write this on the NIP. The full URL and method don't really do anything since they're always the same, no?
mikedilger commented 2024-07-09 17:41:53 +12:00 (Migrated from github.com)
Copy link

The full URL and method don't really do anything since they're always the same, no?

Right.

> The full URL and method don't really do anything since they're always the same, no? Right.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug
Something isn't working

  
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
question
Further information is requested

  
wontfix
This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
nostr/relay-manager!2
No description provided.