Add tests for delegations (sign/verify, delegation()) #6

Merged

optout21 merged 8 commits from deleg-tests into master

2023-03-04 10:42:41 +13:00

optout21 commented

2023-03-03 20:38:27 +13:00

(Migrated from github.com)

added tests for delegations (sign/verify)
added tests to Event::delegation()
fixed a copy-paste error in comparison relation

- added tests for delegations (sign/verify) - added tests to Event::delegation() - fixed a copy-paste error in comparison relation

mikedilger commented

2023-03-04 10:28:30 +13:00

(Migrated from github.com)

Shit. I thought I could change the parameters of verify_signature since it was new and nobody would have used it yet, right? Wrong. I broke your tests. Can you change the 2 calls to verify_signature() to the new parameters (I swapped the order, made them references, and both are pubkeys (neither is hex)).

optout21 commented

2023-03-04 10:31:50 +13:00

(Migrated from github.com)

I've added tests to Event::delegation(), and fixed a copy-paste error in comparison relation.

optout21 commented

2023-03-04 10:35:33 +13:00

(Migrated from github.com)

Can you change the 2 calls to verify_signature() to the new parameters (I swapped the order, made them references, and both are pubkeys (neither is hex)).

Did that, no problem

> Can you change the 2 calls to verify_signature() to the new parameters (I swapped the order, made them references, and both are pubkeys (neither is hex)). Did that, no problem

mikedilger commented

2023-03-04 10:38:43 +13:00

(Migrated from github.com)

Hey! Your tests found a bug! That is what tests are for.
Ready to merge?

Hey! Your tests found a bug! That is what tests are for. Ready to merge?

optout21 commented

2023-03-04 10:40:19 +13:00

(Migrated from github.com)

Ready

mikedilger (Migrated from github.com) approved these changes

2023-03-04 10:42:35 +13:00