Do not include file names in `NOTICE` and `OK` messages #25

Merged

nanikamado merged 1 commit from hide-filenames into master

2024-07-11 15:46:41 +12:00

nanikamado commented

2024-07-11 13:53:00 +12:00

(Migrated from github.com)

Error messages in NOTICE or OK messages contain debug information like this:

["NOTICE","error: JSON bad: Too Short or Missing Fields at position 1, /home/mado/.cargo/git/checkouts/pocket-59454be2808be695/2c90b6c/pocket-types/src/json/json_parse.rs:24:73, src/nostr.rs:23:9"]

It's not quite helpful for relay users, and I don't like exposing file names of my computer.

Error messages in `NOTICE` or `OK` messages contain debug information like this: ``` ["NOTICE","error: JSON bad: Too Short or Missing Fields at position 1, /home/mado/.cargo/git/checkouts/pocket-59454be2808be695/2c90b6c/pocket-types/src/json/json_parse.rs:24:73, src/nostr.rs:23:9"] ``` It's not quite helpful for relay users, and I don't like exposing file names of my computer.

mikedilger commented

2024-07-11 15:46:27 +12:00

(Migrated from github.com)

You are right.

These have been very helpful and have sped up development by at least 50%, but it is time to hide these from network messages (but keep them for log file messages). This PR doesn't cover all of them so I'll push another commit afterwards that gets the rest.

You are right. These have been very helpful and have sped up development by at least 50%, but it is time to hide these from network messages (but keep them for log file messages). This PR doesn't cover all of them so I'll push another commit afterwards that gets the rest.

👍 1