Update base64 to 0.22 #23

Open

jschwe wants to merge 1 commit from jschwe/update_base64_breaking into master

jschwe commented

2026-05-08 20:24:26 +12:00

(Migrated from github.com)

This change is a breaking change for the sized_configured function in our public API,
since it exposes a base64 type that changed.
I'm not sure if this breaking change is acceptable / you would be willing to release a 2.0 release for this.
If that's not the case, then perhaps we could add a legacy feature which pulls in base64 0.13 to preserve the old API, and otherwise use the new version of base64.

This change is a breaking change for the `sized_configured` function in our public API, since it exposes a base64 type that changed. I'm not sure if this breaking change is acceptable / you would be willing to release a `2.0` release for this. If that's not the case, then perhaps we could add a `legacy` feature which pulls in base64 `0.13` to preserve the old API, and otherwise use the new version of base64.

mikedilger commented

2026-05-09 08:17:44 +12:00

(Migrated from github.com)

I don't mind a breaking change. But if we did this, when the upstream changes their version, we have to change ours in another breaking change.

Maybe we should define alphabet constants (upstream has 6) and let users make up their own, and also add a flag for pad/nopad (to me, boolean is enough rather than upstreams PAD NO_PAD) and then map those across to the current upstream.

I don't mind a breaking change. But if we did this, when the upstream changes their version, we have to change ours in another breaking change. Maybe we should define alphabet constants (upstream has 6) and let users make up their own, and also add a flag for pad/nopad (to me, boolean is enough rather than upstreams PAD NO_PAD) and then map those across to the current upstream.

mikedilger commented

2026-05-09 09:25:08 +12:00

(Migrated from github.com)

I pushed a commit to master in this regard. Any feedback on it would be appreciated.

This pull request has changes conflicting with the target branch.

Cargo.toml
src/lib.rs

View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Merge commit title

Merge pull request 'Update base64 to 0.22' (#23) from jschwe/update_base64_breaking into master

Merge commit body

Reviewed-on: https://git.mikedilger.com/mikedilger/textnonce/pulls/23

Merge pull request 'Update base64 to 0.22' (#23) from jschwe/update_base64_breaking into master

Reviewed-on: https://git.mikedilger.com/mikedilger/textnonce/pulls/23

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin jschwe/update_base64_breaking:jschwe/update_base64_breaking

git switch jschwe/update_base64_breaking

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch master

git merge --no-ff jschwe/update_base64_breaking

git switch jschwe/update_base64_breaking

git rebase master

git switch master

git merge --ff-only jschwe/update_base64_breaking

git switch jschwe/update_base64_breaking

git rebase master

git switch master

git merge --no-ff jschwe/update_base64_breaking

git switch master

git merge --squash jschwe/update_base64_breaking