Fix SRV types and glibc compatibility, with some small improvements #9

Merged

de11n merged 4 commits from fixes into master

2024-07-12 10:26:38 +12:00

de11n commented

2024-07-12 06:54:32 +12:00

(Migrated from github.com)

This PR:

Most importantly, fixes the types for SRV priority and weight. This is a backwards incompatible change.
Uses usize instead of u64 to fix the build against glibc headers.
Makes it easier/possible to build this project with glibc headers installed to a different location.
Derives some types to make debugging/usage/testing more convenient.

I'm happy to split these up or make other adjustments as you see fit.

This PR: * Most importantly, fixes the types for SRV priority and weight. This is a backwards incompatible change. * Uses `usize` instead of `u64` to fix the build against glibc headers. * Makes it easier/possible to build this project with `glibc` headers installed to a different location. * Derives some types to make debugging/usage/testing more convenient. I'm happy to split these up or make other adjustments as you see fit.

mikedilger commented

2024-07-12 10:26:42 +12:00

(Migrated from github.com)

Thanks! I haven't used this crate in years. Glad to have another set of eyeballs keeping it honest.

If you think I should publish (and under a new version) I can do that.

Thanks! I haven't used this crate in years. Glad to have another set of eyeballs keeping it honest. If you think I should publish (and under a new version) I can do that.

de11n commented

2024-07-13 06:15:54 +12:00

(Migrated from github.com)

A new release would be nice! Note that this is a backward-incompatible change because the SRV types changed.

Another recent PR (#10) also has backward-incompatible changes, so you may want to wait to release until that is merged (if you decide to merge it as-is).

A new release would be nice! Note that this is a backward-incompatible change because the SRV types changed. Another recent PR (#10) also has backward-incompatible changes, so you may want to wait to release until that is merged (if you decide to merge it as-is).