Updated dependencies, edition and fixed warnings. #10

Merged
golddranks merged 6 commits from update into master 2020-10-01 19:40:13 +13:00
golddranks commented 2020-10-01 04:36:28 +13:00 (Migrated from github.com)

Hi, I did an update to this crate. I know it's an old crate, but there are some old codebases that run on non-async hyper 0.10 with no intention to update for the time being. This version bump would be helpful for those crates.

The commits contain almost mechanistic rewrites and updates, so they should be easy to check commit-by-commit.

Hi, I did an update to this crate. I know it's an old crate, but there are some old codebases that run on non-async hyper 0.10 with no intention to update for the time being. This version bump would be helpful for those crates. The commits contain almost mechanistic rewrites and updates, so they should be easy to check commit-by-commit.
golddranks commented 2020-10-01 04:37:00 +13:00 (Migrated from github.com)

Once https://github.com/mikedilger/textnonce/pull/20 lands, let us consider updating that too, for significant reduction of dependencies.

Once https://github.com/mikedilger/textnonce/pull/20 lands, let us consider updating that too, for significant reduction of dependencies.
mikedilger commented 2020-10-01 19:40:06 +13:00 (Migrated from github.com)

Wow I didn't realize I'd left this crate so far out of date. Thanks for doing this. I've been away from rust projects for a little while now.

Wow I didn't realize I'd left this crate so far out of date. Thanks for doing this. I've been away from rust projects for a little while now.
mikedilger commented 2020-10-01 19:43:33 +13:00 (Migrated from github.com)

let me know if you want a version released.

let me know if you want a version released.
golddranks commented 2020-10-02 00:19:23 +13:00 (Migrated from github.com)

Version bumps for both https://github.com/mikedilger/textnonce and this crate would be nice to have!
I think that textnonce would otherwise be fine with a patch version bump, but I don't know about the minimum supported Rust version, that was likely to have risen because of the new-ish stdlib features I introduced in https://github.com/mikedilger/textnonce/pull/20 , so maybe it's safer to release 0.8.0 for textnonce.

For this crate, with the edition upgrades and all, version 0.6.0 is definitely warranted. However, updating all of the dependencies would be actually bad, because at the moment, the foremost reason to have this crate in one's build is exactly because it supports the old hyper 0.10, mime 0.2 etc. Thus, bumping just textnonce to 0.8.0 and releasing this would be the best, in my mind. Thank you!

Version bumps for both https://github.com/mikedilger/textnonce and this crate would be nice to have! I think that textnonce would otherwise be fine with a patch version bump, but I don't know about the minimum supported Rust version, that was likely to have risen because of the new-ish stdlib features I introduced in https://github.com/mikedilger/textnonce/pull/20 , so maybe it's safer to release 0.8.0 for textnonce. For this crate, with the edition upgrades and all, version 0.6.0 is definitely warranted. However, updating all of the dependencies would be actually bad, because at the moment, the foremost reason to have this crate in one's build is exactly because it supports the old hyper 0.10, mime 0.2 etc. Thus, bumping just textnonce to 0.8.0 and releasing this would be the best, in my mind. Thank you!
mikedilger commented 2020-10-02 07:49:28 +13:00 (Migrated from github.com)

You've got your wish. But I made textnonce 1.0.0 because major changes completed long ago.

You've got your wish. But I made textnonce 1.0.0 because major changes completed long ago.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
mikedilger/mime-multipart!10
No description provided.