mikedilger/mailstrom
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity Actions

Made sure that work with stable rust and updated dependecies #13

Closed
tglman wants to merge 2 commits from master into master
pull from: master
merge into: mikedilger:master
Conversation 5 Commits 2 Files changed 3 +30 -53
tglman commented 2018-06-22 09:30:32 +12:00 (Migrated from github.com)
Copy link
No description provided.
mikedilger commented 2018-06-22 10:19:49 +12:00 (Migrated from github.com)
Copy link

Thanks. I haven't been using this library personally for a while so I depend on users to let me know when it needs attention.

I'm cherry-picking over the 'update dependencies' commit.

I agree with the spirit of the other commit - AtomicU8 never stabilized and we should not be on nightly anymore. However the code changes more things than is strictly necessary for replacing the AtomicU8. I just pushed another commit to do this more directly.

Thanks. I haven't been using this library personally for a while so I depend on users to let me know when it needs attention. I'm cherry-picking over the 'update dependencies' commit. I agree with the spirit of the other commit - AtomicU8 never stabilized and we should not be on nightly anymore. However the code changes more things than is strictly necessary for replacing the AtomicU8. I just pushed another commit to do this more directly.
mikedilger commented 2018-06-22 10:26:29 +12:00 (Migrated from github.com)
Copy link

Let me know if my recent changes work for you.

Let me know if my recent changes work for you.
tglman commented 2018-06-23 05:52:53 +12:00 (Migrated from github.com)
Copy link

hi @mikedilger,

Yes the changes work for me, I tryed to update also to the last lettre version but they changed the API of SendableMail introducing the Envelope and some additiona arror management, but mainly the work is all around here : https://github.com/mikedilger/mailstrom/blob/master/src/prepared_email.rs#L124
so probably is not to hard to upgrate to the last version of that.

Regards

hi @mikedilger, Yes the changes work for me, I tryed to update also to the last lettre version but they changed the API of SendableMail introducing the Envelope and some additiona arror management, but mainly the work is all around here : https://github.com/mikedilger/mailstrom/blob/master/src/prepared_email.rs#L124 so probably is not to hard to upgrate to the last version of that. Regards
tglman commented 2018-06-28 09:15:25 +12:00 (Migrated from github.com)
Copy link

Hi @mikedilger,

Could we get a public relase compatible with stable ?

Regards

Hi @mikedilger, Could we get a public relase compatible with stable ? Regards
mikedilger commented 2018-06-28 09:24:33 +12:00 (Migrated from github.com)
Copy link

Sure.
published as 0.5.0

Sure. published as 0.5.0

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
help wanted

   
invalid

   
question

   
wontfix
No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
mikedilger/mailstrom!13
No description provided.