Add nested multipart/mixed support

SkylerLipthay commented

2015-07-05 01:11:43 +12:00

(Migrated from github.com)

I hope you don't mind that I did some proof-reading and conformed the codebase to a style more consistent with the official, evolving Rust style guide.

I also tried my hand at improving the public interface by reworking the "tuple of vectors of tuples" situation.

Most importantly, this PR should address and close #2. I ended up taking your advice and did not attempt deep multipart/mixed recursion. multipart/mixed sections only support file lists.

There's a fair amount of code duplication in the main tests that should be cleaned up. The state machine is now even beefier and could use some splitting up.

I hope you don't mind that I did some proof-reading and conformed the codebase to a style more consistent with the official, evolving Rust style guide. I also tried my hand at improving the public interface by reworking the "tuple of vectors of tuples" situation. Most importantly, this PR should address and close #2. I ended up taking your advice and did not attempt deep `multipart/mixed` recursion. `multipart/mixed` sections only support file lists. There's a fair amount of code duplication in the main tests that should be cleaned up. The state machine is now even beefier and could use some splitting up.

SkylerLipthay commented

2015-07-08 13:28:40 +12:00

(Migrated from github.com)

Rebased to 0.3.1 master

mikedilger commented

2015-07-09 01:51:31 +12:00

(Migrated from github.com)

I apologise, this PR slipped through the cracks somehow, I didn't notice until just now (and I'm not at the computer). Thanks for your hard work, I'll look at it in the morning.

mikedilger commented

2015-07-09 02:37:55 +12:00

(Migrated from github.com)

eh, I couldn't sleep.

This is just brilliant work Skyler. Thanks. I've merged it over my latest changes.

eh, I couldn't sleep. This is just brilliant work Skyler. Thanks. I've merged it over my latest changes.

SkylerLipthay commented

2015-07-09 09:35:33 +12:00

(Migrated from github.com)

Thanks for the merge! I'm successfully using this crate over at iron/params. The web app story is slowly coming together for Rust. 😄

Thanks again for your valuable work.

Thanks for the merge! I'm successfully using this crate over at [`iron/params`](https://github.com/iron/params). The web app story is slowly coming together for Rust. :smile: Thanks again for your valuable work.

mikedilger commented

2015-07-09 16:44:24 +12:00

(Migrated from github.com)

If I had the time to upgrade my webtech to Iron I would definitely consider iron/params. I've tried changing over to iron several times and fell into fits of mis-comprehension. I'll try iron again at some point.

Rows
Columns

Add nested multipart/mixed support #9