bump hyper and mime vers

kavorite commented

2017-09-10 16:10:42 +12:00

(Migrated from github.com)

No description provided.

mikedilger commented

2017-09-10 19:12:20 +12:00

(Migrated from github.com)

I see that this requires also your changes to the mime-multipart crate. I'll start there.

Don't expect a quick turnaround as I'm pretty busy tonight and tomorrow is my Monday which is always busy.

I see that this requires also your changes to the mime-multipart crate. I'll start there. Don't expect a quick turnaround as I'm pretty busy tonight and tomorrow is my Monday which is always busy.

kavorite commented

2017-09-11 02:29:03 +12:00

(Migrated from github.com)

Understood. I'll start work on tests. Thank you!

On Sun, Sep 10, 2017 at 3:12 AM, Michael Dilger notifications@github.com
wrote:

I see that this requires also your changes to the mime-multipart crate.
I'll start there.

Don't expect a quick turnaround as I'm pretty busy tonight and tomorrow is
my Monday which is always busy.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/mikedilger/formdata/pull/37#issuecomment-328324624,
or mute the thread
https://github.com/notifications/unsubscribe-auth/APKSuAY1LZbG2nAgq0x46663_q7xxbXXks5sg4vUgaJpZM4PSMx7
.

Understood. I'll start work on tests. Thank you! On Sun, Sep 10, 2017 at 3:12 AM, Michael Dilger <notifications@github.com> wrote: > I see that this requires also your changes to the mime-multipart crate. > I'll start there. > > Don't expect a quick turnaround as I'm pretty busy tonight and tomorrow is > my Monday which is always busy. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/mikedilger/formdata/pull/37#issuecomment-328324624>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/APKSuAY1LZbG2nAgq0x46663_q7xxbXXks5sg4vUgaJpZM4PSMx7> > . >

mikedilger commented

2017-09-12 09:25:44 +12:00

(Migrated from github.com)

hyper 11 is really quite a different paradigm. It leaves me thinking that the public interfaces of mime-multipart and formdata are not appropriate in the tokio-based world... not that they couldn't work (your forks show that), but that when used this way you lose the asynchronicity (e.g. read_formdata() will block and your asynchronous server will not progress until read_formdata() has completed).

Personally I'm leaning towards entirely new crates, perhaps called mime-mulitpart-async and formdata-async. I think hyper should have done that too.. so that the synchronous code could continue to be developed.

hyper 11 is really quite a different paradigm. It leaves me thinking that the public interfaces of mime-multipart and formdata are not appropriate in the tokio-based world... not that they couldn't work (your forks show that), but that when used this way you lose the asynchronicity (e.g. read_formdata() will block and your asynchronous server will not progress until read_formdata() has completed). Personally I'm leaning towards entirely new crates, perhaps called `mime-mulitpart-async` and `formdata-async`. I think hyper should have done that too.. so that the synchronous code could continue to be developed.

kavorite commented

2017-09-12 09:51:40 +12:00

(Migrated from github.com)

Have you thought about whether you're going to employ nightly features?

On Sep 11, 2017 5:25 PM, "Michael Dilger" notifications@github.com wrote:

hyper 11 is really quite a different paradigm. It leaves me thinking that
the public interfaces of mime-multipart and formdata are not appropriate in
the tokio-based world... not that they couldn't work (your forks show
that), but that when used this way you lose the asynchronicity (e.g.
read_formdata() will block and your asynchronous server will not progress
until read_formdata() has completed).

Personally I'm leaning towards entirely new crates, perhaps called
mime-mulitpart-async and formdata-async. I think hyper should have done
that too.. so that the synchronous code could continue to be developed.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/mikedilger/formdata/pull/37#issuecomment-328663261,
or mute
the thread
https://github.com/notifications/unsubscribe-auth/APKSuL7nSGifLdvk5rf6ySDdq99gn8FMks5shaVYgaJpZM4PSMx7
.

Have you thought about whether you're going to employ nightly features? On Sep 11, 2017 5:25 PM, "Michael Dilger" <notifications@github.com> wrote: hyper 11 is really quite a different paradigm. It leaves me thinking that the public interfaces of mime-multipart and formdata are not appropriate in the tokio-based world... not that they couldn't work (your forks show that), but that when used this way you lose the asynchronicity (e.g. read_formdata() will block and your asynchronous server will not progress until read_formdata() has completed). Personally I'm leaning towards entirely new crates, perhaps called mime-mulitpart-async and formdata-async. I think hyper should have done that too.. so that the synchronous code could continue to be developed. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <https://github.com/mikedilger/formdata/pull/37#issuecomment-328663261>, or mute the thread <https://github.com/notifications/unsubscribe-auth/APKSuL7nSGifLdvk5rf6ySDdq99gn8FMks5shaVYgaJpZM4PSMx7> .

mikedilger commented

2017-09-13 19:55:45 +12:00

(Migrated from github.com)

I don't think nightly features would be needed

mikedilger commented

2023-09-30 06:56:07 +13:00

(Migrated from github.com)

Closing to to archival status

Pull request closed

Please reopen this pull request to perform a merge.

Rows
Columns

bump hyper and mime vers #37

Pull request closed