mikedilger/formdata
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

BufReadPlus token 'partial' should be a vec #12

New issue
Closed
opened 2015-07-09 01:55:18 +12:00 by mikedilger · 3 comments
mikedilger commented 2015-07-09 01:55:18 +12:00 (Migrated from github.com)
Copy link

For example, a token '---boundary' might be preceded with more hyphens in which case multiple partial offsets could indicate the token. And '--' at the end of a buffer might be followed by '--boundary' in the next buffer in which case the 2nd hyphen was the partial (but our code only checked one partial possibility).

For example, a token '---boundary' might be preceded with more hyphens in which case multiple partial offsets could indicate the token. And '--' at the end of a buffer might be followed by '--boundary' in the next buffer in which case the 2nd hyphen was the partial (but our code only checked one partial possibility).
mikedilger commented 2015-07-09 02:45:34 +12:00 (Migrated from github.com)
Copy link

Makes sense to fix this along with #11.

Makes sense to fix this along with #11.
mikedilger commented 2015-07-09 05:06:39 +12:00 (Migrated from github.com)
Copy link

Test cases:
Token=barbarian
Case1: barbar|ian123 output '123'
Case2: barbar|barian output 'bar'

Test cases: Token=barbarian Case1: barbar|ian123 output '123' Case2: barbar|barian output 'bar'
mikedilger commented 2015-07-09 16:31:26 +12:00 (Migrated from github.com)
Copy link

fixed in b1cd8cff54

fixed in b1cd8cff54a144b07771bf244d711095f7f0bbd3
This discussion has been locked. Commenting is limited to contributors.
No Branch/Tag specified
Branches Tags
master
0.13
gh-pages
0.13.0
0.12.3
0.12.2
0.12.1
0.12.0
0.11.0
0.10.0
0.9.0
0.8.4
0.8.3
0.8.2
0.8.1
0.8.0
0.7.10
0.7.9
0.7.8
0.7.7
0.7.6
0.7.5
0.7.4
0.7.3
0.7.2
0.7.1
0.7.0
0.6.1
0.6.0
0.5.0
0.4.0
0.3.1
0.3.0
0.2.1
0.2.0
0.1.0
Labels
Clear labels   
P-high

   
P-low

   
bug

   
duplicate

   
enhancement

   
help wanted

   
invalid

   
question

   
wontfix
No labels
P-high
P-low
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
mikedilger/formdata#12
No description provided.