BufReadPlus with tokens larger than the underlying buffer capacity still wrong #11

New issue

Closed

opened 2015-07-08 16:56:45 +12:00 by mikedilger · 0 comments

mikedilger commented

2015-07-08 16:56:45 +12:00

(Migrated from github.com)

This could be fixed without too much code upheaval, with an extension of the partial concept.

Medium priority, as this is now less likely (the fully-sized stream buffer would actually have to be smaller than the token, not just the remaining stream buffer).

BufReadPlus::read_until_token() will not perform properly if the token is larger than the underlying buffer capacity, whenever the token spans three or more buffer read segments. E.g., when we find a partial, then we find more partial, then we find the end of the token. This could be fixed without too much code upheaval, with an extension of the partial concept. Medium priority, as this is now less likely (the fully-sized stream buffer would actually have to be smaller than the token, not just the remaining stream buffer).

This discussion has been locked. Commenting is limited to contributors.