Private chat / Conversation UI

dtonon commented

2024-06-25 07:37:58 +12:00

(Migrated from github.com)

I propose this quick redesign, primary intended to highlight the new NIP-17 DM:

A label identifying the encryption mode, with an information pop-up describing its features/limits; I'm not sure about the "Basic encryption" definition, maybe we need to emphasize that it's weak?
Top "Last notes" and "Profile" buttons;
Update the icon for the message preferences, using the standard icon used everywhere;

@bu5hm4nn I will create a different issue for the info popover component.

I propose this quick redesign, primary intended to highlight the new NIP-17 DM: - A label identifying the encryption mode, with an information pop-up describing its features/limits; I'm not sure about the "Basic encryption" definition, maybe we need to emphasize that it's weak? - Top "Last notes" and "Profile" buttons; - Update the icon for the message preferences, using the standard icon used everywhere; <img width="952" alt="image" src="https://github.com/mikedilger/gossip/assets/89577423/9e0435e2-5e83-4324-8476-d3f281258e97"> <img width="946" alt="image" src="https://github.com/mikedilger/gossip/assets/89577423/03d589ae-b712-4dc6-abcf-5872f913b517"> <br/><br/> @bu5hm4nn I will create a different issue for the info popover component.

mikedilger commented

2024-06-25 11:49:49 +12:00

(Migrated from github.com)

Each message in your DM feed could be either weak or strong. Maybe we should highlight each message.

dtonon commented

2024-06-25 21:22:54 +12:00

(Migrated from github.com)

Right, let's mark the weak messages.
We can apply the info popover here, too.

Right, let's mark the weak messages. We can apply the info popover here, too. <img width="947" alt="image" src="https://github.com/mikedilger/gossip/assets/89577423/6d921351-b2e2-4560-9cde-1e49df95e835">

👍 1

dtonon commented

2024-07-03 04:48:16 +12:00

(Migrated from github.com)

Update:

Update: <img width="941" alt="Screenshot 2024-07-02 at 18 45 59" src="https://github.com/mikedilger/gossip/assets/89577423/0dbb7c6a-c482-4e8b-ac78-ecef56d583e1"> <img width="941" alt="Screenshot 2024-07-02 at 18 45 06" src="https://github.com/mikedilger/gossip/assets/89577423/992670d8-d901-4d63-b2c1-69685fa9043a"> <img width="941" alt="Screenshot 2024-07-02 at 18 47 35" src="https://github.com/mikedilger/gossip/assets/89577423/ad03752b-113a-4622-8d11-5d70c3b7c3bd">

bu5hm4nn commented

2024-07-06 09:28:10 +12:00

(Migrated from github.com)

After fiddling with the note rendering for quite a while I have the following to say
a) currently rendering and parsing the note are not separate, they are inter-twined all the way down to showing shattered content
b) this means that refactoring only a part of the code is virtually impossible / or could have huge hard-to test consequences since many code paths only show on certain note content.

So unfortunately that means I need to re-write note rendering in order to create the design proposed here for DM's. That is not a bad thing, but it means this would be delayed by at least another week (with testing).

I would suggest planning a re-write of note rendering, but combining it with creating automated tests (where we create a folder of json test data for different note scenarios), so that we can start assure good results.

For now I suggest using this simplified note display for DMs:
Screenshot 2024-07-05 at 23 29 28

After fiddling with the note rendering for quite a while I have the following to say a) currently rendering and parsing the note are not separate, they are inter-twined all the way down to showing shattered content b) this means that refactoring only a part of the code is virtually impossible / or could have huge hard-to test consequences since many code paths only show on certain note content. So unfortunately that means I need to re-write note rendering in order to create the design proposed here for DM's. That is not a bad thing, but it means this would be delayed by at least another week (with testing). I would suggest planning a re-write of note rendering, but combining it with creating automated tests (where we create a folder of json test data for different note scenarios), so that we can start assure good results. For now I suggest using this simplified note display for DMs: <img width="1011" alt="Screenshot 2024-07-05 at 23 29 28" src="https://github.com/mikedilger/gossip/assets/3328670/4b151dfc-0234-4d10-b5dd-984c773094a2">

mikedilger commented

2024-07-08 08:32:56 +12:00

(Migrated from github.com)

ok

dtonon commented

2024-07-08 09:01:48 +12:00

(Migrated from github.com)

I would suggest planning a re-write of note rendering

I was planning to redesign it, I will go on.

For now I suggest using this simplified note display for DMs:

Ok.
Is it possibile at least to hide the useless bullet button that point to the current note?

> I would suggest planning a re-write of note rendering I was planning to redesign it, I will go on. > For now I suggest using this simplified note display for DMs: Ok. Is it possibile at least to hide the useless bullet button that point to the current note?

bu5hm4nn commented

2024-07-08 23:44:50 +12:00

(Migrated from github.com)

Regarding the tooltip for the encryption strength indicator. I would recommed we write a detailed explanation on how to switch to Giftwrap encryption on the help pages and link to that page in the tooltip. Unless someone writes a text first I will just write one up which can then be improved.

🚀 1

bu5hm4nn commented

2024-07-10 09:24:05 +12:00

(Migrated from github.com)

A few small things missing, but please review @dtonon. I also need us all to check that I didn't break main feed note rendering. https://github.com/mikedilger/gossip/pull/807

dtonon commented

2024-07-12 05:08:36 +12:00

(Migrated from github.com)

@bu5hm4nn it's ok, you can just add more space between the elements on bottom-right (indicator, date, seen on).

Some more notes:

If a DM is a reply the parent overlap the name; we can also simply hide the link for the time being;
If a DM uses NIP-44 we should treat it as the default situation, so I would not show anything, or at least not a green dot, it is too prominent; if we want to highlight the new encryption, lets use a dot with a very dark gray;
Remove "DIRECT MESSAGE TO: dtonon", it is not necessary;

To do:

Add the encryption badge that partially overlap the compose area (let me know if it is too complex, we can find an alternative solution)
Add the top right button "Last notes" and "Profile"

@bu5hm4nn it's ok, you can just add more space between the elements on bottom-right (indicator, date, seen on). Some more notes: <img width="760" alt="image" src="https://github.com/mikedilger/gossip/assets/89577423/7667bd94-1c53-417d-9352-49e264f50137"> <br/><br/> * If a DM is a reply the parent overlap the name; we can also simply hide the link for the time being; * If a DM uses NIP-44 we should treat it as the default situation, so I would not show anything, or at least not a green dot, it is too prominent; if we want to highlight the new encryption, lets use a dot with a very dark gray; * Remove "_DIRECT MESSAGE TO: dtonon_", it is not necessary; To do: * Add the encryption badge that partially overlap the compose area (let me know if it is too complex, we can find an alternative solution) * Add the top right button "Last notes" and "Profile"

dtonon commented

2024-07-12 05:28:08 +12:00

(Migrated from github.com)

About the action menu, I would organizer it this way:


Copy text
- To clipboard
- Via QR Code

Manage
- Delete
- Annotate
- Rebrodcast (X)

Bookmark
- Public
- Private

Copy ID
- Nevent
- Note
- Hex

Debug
- Show Json
- Copy Json
- Rerender
- Dismiss

The annotate doesn't seem to work for me.
Would be nice show the QR Code and the Json in a modal; it is prettier and also easier to revert (close button).

About the action menu, I would organizer it this way: ``` Copy text - To clipboard - Via QR Code Manage - Delete - Annotate - Rebrodcast (X) Bookmark - Public - Private Copy ID - Nevent - Note - Hex Debug - Show Json - Copy Json - Rerender - Dismiss ``` The annotate doesn't seem to work for me. Would be nice show the QR Code and the Json in a modal; it is prettier and also easier to revert (close button).

Rows
Columns

Private chat / Conversation UI #798