Relay List at-a-glance issues #466
Labels
No labels
Blocked
Bug
Documentation
Duplicate
Enhancement
Good first issue
Help wanted
Idea
In progress
Invalid
Major feature set
Packaging
Question
Soon
UI/UX
Upstream
You're dreamin'
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
nostr/gossip#466
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
With the new relay lists:
@bu5hm4nn
@mikedilger What do you think of these short stats for the list view. Backgrounds of those numbers could be color coded (e.g. over 85% green, over 50% yellow, red below).
or with key symbols
Color coding would make it easier to see. A fixed column would too, but that probably doesn't suit this layout. Person or key works for me, either way.
I've experimented putting the stats in front so it kind of works like a column. Thoughts? @dtonon ?
Sorry I didn't see this issue!
(@mikedilger feel free to mention me)
This situation is a regression "bug" caused by hiding the stats under a flag.
Also it is not optimal to have a sorting mechanism that acts on a value that is not immediately visible.
I think that a solution could be, in the compact mode view on the right of the relay name, to dynamically show only the value used in the sort select (rank + connections, following, success rate, failure rate). I like the proposal by @bu5hm4nn to use the darker-rounded box already applied in the gossip model synthetic view.
What do you think?
I would improve the expanded view too; currently, with the addition of the "actions" there is a lot of text and on two lines it is not so readable (I know, Mike, a table would solve this! But it would add other problems).
If you are ok with this path I can update the figma design and share it.
I sketched a new version. Let me know what do you think.
The compact view includes the data used in the sorting; the reasons are omitted.
We have plenty of space to include more important info in the future, if needed.
This way it should work fine even when the window is set with a limited width (I usually try it with a minimum of ~800px).
The datails view include the full data, reasons included.
As you can see the gears-button on the top left vanished. I would let the user enter in edit mode just click the row.
Now the pointer cursor signals this possibility, but we can add a more prominent hover effect, if needed.
The edit view includes all the data in the details view and expands further on the bottom.
I see myself as the quintessential gossip user, so I ask myself "what do I want to see?" I think gossip users are the kind of people that want to know how many relays they are talking to, why so many, what are they doing exactly, ... to have the ability to force disconnect, to force one to never connect again, to really understand (but not at a code level!) what the fuck is going on when their CPU is hot or their network is congested, etc.
So that's why the reasons are there. They only matter on the "Active Relays" tab, only those relays have reasons. We can rework the reasons code to not be strings, but be enum variants, and then it is more obvious all the possibilities and you can display them as icons (which I still like).
@mikedilger
Ok let's move them back to the compact view.
Icons could be a good solution.
What do you think about dynamically displayed data based on the sorting filter?
So I pushed some commits that turned those reason strings into RelayConnectionReason enum variants. Feel free to make an icon() function or whatever.
Also, it doesn't show the same old string, they are reworded a bit for consistency and currently they are CamelCase because I'm just using the Debug impl.
Also I swapped the [brackets] to mean a temporary connection rather than a longterm one (so it would be rare, rather than everything being in brackets all the time). This probably doesn't matter if we move to icons.
@mikedilger after you saw that the top-right popover enable the statistic, that includes the reasons, you still want the reasons in the compact view?
Yes, on the Active relays page.
We've made this widget that shows a relay line the same way on all the relay pages. But the pages have different purposes. My Relays and Known Network is for configuration [might want to show rate(total) and last event] and Active Relays is for monitoring [should show reasons, how many followed].
@mikedilger ok, I will update the design!
I agree that offer the right information in the context is important; I was proposing a unique row as temp solution to simplify @bu5hm4nn's works and avoid splitting too many components.
@mikedilger @bu5hm4nn update.
I would keep the text-descriptive version and eventually switch to icons when we will finish all the sections with related priorities (ex. buttons / popovers).
This part is done.