mikedilger/textnonce
1
Fork 0
Code Issues Pull requests 2 Projects Releases Packages Wiki Activity Actions

Remove unsafe block in function sized_configured #17

New issue
Closed
opened 2019-07-23 05:06:27 +12:00 by ZephOne · 2 comments
ZephOne commented 2019-07-23 05:06:27 +12:00 (Migrated from github.com)
Copy link

Would it be possible to get rid of the unsafe block in the function sized_configured and use resize instead ? Is it important that spaces of the vector are not initialized before starting to write into the vector ? I am aware that the unsafe block is totally controlled, it's just to avoid presence of unsafe block.

Would it be possible to get rid of the unsafe block in the function sized_configured and use resize instead ? Is it important that spaces of the vector are not initialized before starting to write into the vector ? I am aware that the unsafe block is totally controlled, it's just to avoid presence of unsafe block.
mikedilger commented 2019-07-23 09:49:34 +12:00 (Migrated from github.com)
Copy link

I suppose the performance impact is almost always trivial, so I'd merge it if you submitted a PR.

I suppose the performance impact is almost always trivial, so I'd merge it if you submitted a PR.
ZephOne commented 2019-07-23 09:53:25 +12:00 (Migrated from github.com)
Copy link

Perfect, I got it on my machine. I fork and submit the PR

Perfect, I got it on my machine. I fork and submit the PR
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
1.0
0.7
gh-pages
1.0.0
0.7.1
0.7.0
0.6.5
0.6.4
0.6.3
0.6.2
0.6.1
0.6.0
0.5.0
0.4.1
0.4
0.3.4
0.3.3
0.3.2
0.3.1
0.3.0
0.2.6
0.2.4
0.2.3
0.2.2
0.2.1
0.2.0
0.1.2
0.1.1
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
help wanted

   
invalid

   
question

   
wontfix
No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
mikedilger/textnonce#17
No description provided.