Provide labels when a cycle is detected #12

New issue

Open

opened 2021-12-22 17:53:21 +13:00 by milesj · 3 comments

milesj commented

2021-12-22 17:53:21 +13:00

(Migrated from github.com)

Right now the cycle detection isn't very helpful since it doesn't tell you where the actual problem is.

It would be nice if it included a vector of the cycle path that triggered it, for example: SolventError::CycleDetected(vec!["foo", "bar", "baz", "foo"]).

Right now the cycle detection isn't very helpful since it doesn't tell you where the actual problem is. It would be nice if it included a vector of the cycle path that triggered it, for example: `SolventError::CycleDetected(vec!["foo", "bar", "baz", "foo"])`.

mikedilger commented

2021-12-23 08:29:15 +13:00

(Migrated from github.com)

I just pushed a commit that should do what you want. It passes internal tests, but I haven't used it myself (I haven't used solvent in years). Let me know if it works for you.

milesj commented

2021-12-23 12:49:27 +13:00

(Migrated from github.com)

@mikedilger Not seeing any commit :P