BufReadPlus with tokens larger than the underlying buffer capacity #1

Closed
opened 2015-06-11 12:33:02 +12:00 by mikedilger · 2 comments
mikedilger commented 2015-06-11 12:33:02 +12:00 (Migrated from github.com)

BufReadPlus::read_until_token() will not perform properly if the token is larger than the underlying buffer capacity.

This could be fixed without much code upheaval, with an extension of the partial concept.

BufReadPlus::read_until_token() will not perform properly if the token is larger than the underlying buffer capacity. This could be fixed without much code upheaval, with an extension of the `partial` concept.
mikedilger commented 2015-07-08 16:19:38 +12:00 (Migrated from github.com)

The buffer gets smaller and smaller as we parse bits off of it, and eventually it very well could be shorter than the size of the token. So this bug has been escalated now to P-high, as it is not just a rare possibility but actually very likely.

The buffer gets smaller and smaller as we parse bits off of it, and eventually it very well could be shorter than the size of the token. So this bug has been escalated now to P-high, as it is not just a rare possibility but actually very likely.
mikedilger commented 2015-07-08 16:52:33 +12:00 (Migrated from github.com)

fixed in 26dd0b9683

fixed in 26dd0b96836963ae608186aaa431d59d8b379f5a
This discussion has been locked. Commenting is limited to contributors.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
mikedilger/formdata#1
No description provided.